Skip to content

Remove useless checks in Jac#276

Merged
ValerianRey merged 3 commits intomainfrom
simplify-jac
Mar 26, 2025
Merged

Remove useless checks in Jac#276
ValerianRey merged 3 commits intomainfrom
simplify-jac

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented Mar 26, 2025

  • Remove check that is impossible to fail in _differentiate
  • Remove check that is impossible to fail in _extract_sub_matrices.
  • Remove check that is impossible to fail in _reshape_matrices

@ValerianRey ValerianRey added package: autojac cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements labels Mar 26, 2025
@ValerianRey ValerianRey self-assigned this Mar 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/autojac/_transform/jac.py 100.00% <100.00%> (+4.61%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValerianRey ValerianRey merged commit 99e8bea into main Mar 26, 2025
14 checks passed
@ValerianRey ValerianRey deleted the simplify-jac branch March 26, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements package: autojac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants